bug fix 4127. Restore RSA support for x509 public key import on PKCS11 #4128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR. A couple of Qs/remarks:
|
|
@ale-linux It looks like it was only restored for SW implementation, so it makes sense to restore for PKCS11 implementation as well. |
|
LGTM @marianothiago , if you follow the DCO and fix that issue, I think we're ready to merge! |
…tificates that included RSA public keys Signed-off-by: Thiago Mariano <mariano.thiago@gmail.com>
marianothiago
force-pushed
the
issue-4127-PKCS11-dont-support-CA-with-RSA-public-key
branch
from
a80c108
to
46cfd7d
Compare
ale-linux
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
While RSA has never been supported by Fabric for transaction signing and
verification, prior to version 2.x, MSPs could include CA certificates
that included RSA public keys. This was broken with the removal of the
unsupported RSA code.
It was fixed in SW but the error is still in PKCS11
This change modifies the key import function used by the MSP on PKCS11 to convert
an RSA public key to a bccsp.Key that can then be used as part of an MSP
identity.
This code does not add support for RSA on transaction paths.
Additional details
Related issues
#4127