Deduplicate orderer server TLS root CAs #2029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacovm
changed the title
When the orderer TLS root CAs are updated, an aggregation of all root TLS CA certificates over all channels is injected into the PredicateDialer. Then, upon client TLS handshake, a fresh TLS config object is built (for orthogonal purposes), however the operation entails parsing of all root CAs all over again. In case the orderer is part of too many channels, this induces a high and unnecessary processing overhead. This commit simply performs a deduplication of the bespoken TLS root CA certificates prior to updating the root CAs. Change-Id: I21b2ed483afc9595c2ccd7fbe9ec0cf475cc5f62 Signed-off-by: yacovm <yacovm@il.ibm.com>
yacovm
force-pushed
the
deduplicateServerRootCAs
branch
from
b0ab47e
to
dddad1a
Compare
|
@Mergifyio backport release-2.2 |
|
Command
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 21, 2020
When the orderer TLS root CAs are updated, an aggregation of all root TLS CA certificates over all channels is injected into the PredicateDialer. Then, upon client TLS handshake, a fresh TLS config object is built (for orthogonal purposes), however the operation entails parsing of all root CAs all over again. In case the orderer is part of too many channels, this induces a high and unnecessary processing overhead. This commit simply performs a deduplication of the bespoken TLS root CA certificates prior to updating the root CAs. Change-Id: I21b2ed483afc9595c2ccd7fbe9ec0cf475cc5f62 Signed-off-by: yacovm <yacovm@il.ibm.com> (cherry picked from commit 48d532f) # Conflicts: # orderer/common/server/main_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the orderer TLS root CAs are updated, an aggregation of all root TLS CA certificates over all channels is injected into the PredicateDialer.
Then, upon client TLS handshake, a fresh TLS config object is built (for orthogonal purposes), however the operation entails parsing of all
root CAs all over again.
In case the orderer is part of too many channels, this induces a high and unnecessary processing overhead.
This commit simply performs a deduplication of the bespoken TLS root CA certificates prior to updating the root CAs.
Change-Id: I21b2ed483afc9595c2ccd7fbe9ec0cf475cc5f62
Signed-off-by: yacovm yacovm@il.ibm.com