Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG.md #2759

Merged
merged 1 commit into from Jul 23, 2021
Merged

Update CHANGELOG.md #2759

merged 1 commit into from Jul 23, 2021

Conversation

denyeart
Copy link
Contributor

Update CHANGELOG.md to indicate that the changelog is now maintained in GitHub.

Signed-off-by: David Enyeart enyeart@us.ibm.com

@denyeart denyeart requested a review from a team as a code owner July 16, 2021 18:17
@denyeart denyeart force-pushed the changelog_update branch 2 times, most recently from f7b57c1 to 2817231 Compare July 16, 2021 18:21
@denyeart
Copy link
Contributor Author

@C0rWin it looks like the integration test failures are related to the recently merged #2748

@C0rWin
Copy link
Contributor

C0rWin commented Jul 16, 2021

@C0rWin it looks like the integration test failures are related to the recently merged #2748

Indeed, I will take a look at it, thanks @denyeart

@C0rWin
Copy link
Contributor

C0rWin commented Jul 17, 2021

ChannelParticipation three node etcdraft network with a system channel [It] joins channels using the legacy channel creation mechanism and then removes the system channel to transition to the channel participation API 
/home/vsts/work/1/fabric/integration/raft/channel_participation_test.go:1060

  Timed out after 60.840s.
  Expected
      <channelparticipation.ChannelInfo>: {
          Name: "testchannel",
          URL: "/participation/v1/channels/testchannel",
          Status: "active",
          ConsensusRelation: "consenter",
          Height: 6,
      }
  to equal
      <channelparticipation.ChannelInfo>: {
          Name: "testchannel",
          URL: "/participation/v1/channels/testchannel",
          Status: "inactive",
          ConsensusRelation: "config-tracker",
          Height: 6,
      }

  /home/vsts/work/1/fabric/integration/raft/channel_participation_test.go:1133

is it also a known flake?

@denyeart
Copy link
Contributor Author

@C0rWin Yes that is the most common flake for the last year, Param is actually investigating it now - https://jira.hyperledger.org/browse/FAB-18365

@denyeart
Copy link
Contributor Author

@C0rWin I rebased on top of your fix but the integration test is still failing.

@C0rWin
Copy link
Contributor

C0rWin commented Jul 23, 2021

@C0rWin I rebased on top of your fix but the integration test is still failing.

Can you give a try with this one? #2779

Update CHANGELOG.md to indicate that the changelog is now maintained in GitHub.

Signed-off-by: David Enyeart <enyeart@us.ibm.com>
@C0rWin
Copy link
Contributor

C0rWin commented Jul 23, 2021

@denyeart I guess it's better now, right?

@C0rWin C0rWin merged commit 71037f3 into hyperledger:main Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants