Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed typo. #323

Merged
merged 1 commit into from
Dec 3, 2019
Merged

fixed typo. #323

merged 1 commit into from
Dec 3, 2019

Conversation

Shubham-koli
Copy link
Contributor

@Shubham-koli Shubham-koli commented Nov 27, 2019

Signed-off-by: Shubham Koli shubham.koli@outlook.in

Type of change

  • Documentation update

Description

Additional details

Related issues

yacovm
yacovm previously approved these changes Nov 27, 2019
Copy link
Contributor

@yacovm yacovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not a typo.... but OK.

nikhil550
nikhil550 previously approved these changes Nov 27, 2019
guoger
guoger previously requested changes Nov 28, 2019
Copy link
Member

@guoger guoger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for your contribution

DCO needs to be fixed, you could git commit --amend --signoff then do a force push.

Also, pls remove unneeded fields in commit message template

kchristidis
kchristidis previously approved these changes Nov 29, 2019
@guoger guoger self-requested a review November 29, 2019 06:18
@guoger
Copy link
Member

guoger commented Nov 29, 2019

DCO problem has not been fixed, make sure you do git commit --amend -s (not manually adding the sign off line)

removed redundant comma.

Signed-off-by: Shubham Koli (FaultyCarry) <37935825+shubham-koli@users.noreply.github.com>
Signed-off-by: Ubuntu <ubuntu@ip-172-31-13-70.ap-south-1.compute.internal>
@Shubham-koli
Copy link
Contributor Author

I think DCO error has been resolved.

@jyellick jyellick dismissed guoger’s stale review December 3, 2019 15:25

The DCO problem has been fixed.

@jyellick jyellick merged commit c0f019e into hyperledger:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants