FAB-17158 ignore util test using build tag #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guoger
requested review from
ale-linux,
binhn,
C0rWin,
christo4ferris,
denyeart,
jyellick,
kchristidis,
manish-sethi,
mastersingh24,
muralisrini,
sykesm and
yacovm
as code owners
ledger_generate_test is used to generate test data, and is currently skipped by default. However, it still runs BeforeEach and AfterEach, which brings up a Fabric network, which is heavy, and leaves garbage data dir behind. This patch adds a build tag 'generate' to file. Test done: run `ginkgo -tags generate` to see that test being executed, and `ginkgo` to see it being excluded. Signed-off-by: Jay Guo <guojiannan1101@gmail.com>
guoger
force-pushed
the
FAB-17158-ignore-test
branch
from
529d07d
to
027d751
Compare
|
cc @wenjianqiao |
denyeart
approved these changes
Nov 29, 2019
manish-sethi
approved these changes
Nov 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ledger_generate_test is used to generate test data, and is currently
skipped by default. However, it still runs BeforeEach and AfterEach,
which brings up a Fabric network, which is heavy, and leaves garbage
data dir behind. This patch adds a build tag 'generate' to file.
Test done: run
ginkgo -tags generateto see that test being executed,and
ginkgoto see it being excluded.Signed-off-by: Jay Guo guojiannan1101@gmail.com