-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix FAB-17148 defer to delete 'bccsp-sw' directory #328
Conversation
Signed-off-by: baidang201 <jinrishouji@sina.com>
bccsp/sw/impl_test.go
Outdated
@@ -76,10 +80,10 @@ func TestMain(m *testing.M) { | |||
ret := m.Run() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this could be code = m.Run()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
Signed-off-by: baidang201 <jinrishouji@sina.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix
* fix FAB-17148 defer to delete 'bccsp-sw' directory Signed-off-by: baidang201 <jinrishouji@sina.com> * 1 set code = m.Run 2 delete not user 'code =0' at last line Signed-off-by: baidang201 <jinrishouji@sina.com>
* fix FAB-17148 defer to delete 'bccsp-sw' directory Signed-off-by: baidang201 <jinrishouji@sina.com> * 1 set code = m.Run 2 delete not user 'code =0' at last line Signed-off-by: baidang201 <jinrishouji@sina.com> Signed-off-by: Hakan Eryargi <hakan.eryargi@gmail.com>
* fix FAB-17148 defer to delete 'bccsp-sw' directory Signed-off-by: baidang201 <jinrishouji@sina.com> * 1 set code = m.Run 2 delete not user 'code =0' at last line Signed-off-by: baidang201 <jinrishouji@sina.com>
Signed-off-by: baidang201 jinrishouji@sina.com
Type of change
Bug fix
Description
fix when unit test in bccsp\sw,we find in the /tmp folder, has a lot of file like 'bccsp-sw' and can not delete auto by test program.
Additional details
the reason is when os.exit, it do not run defer to delete 'bccsp-sw' folder.
we can put os.exit in the head of function and import another defer for os.exit.
Related issues
https://jira.hyperledger.org/browse/FAB-17148