replace http with https in install.rst #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnlctrl
requested review from
ale-linux,
binhn,
C0rWin,
christo4ferris,
denyeart,
guoger,
jyellick,
kchristidis,
manish-sethi,
mastersingh24,
muralisrini,
sykesm and
yacovm
as code owners
ale-linux
previously approved these changes
Dec 1, 2019
|
Please follow the steps here to add your signature to your commit, we require all commits to be signed by their authors: https://github.com/hyperledger/fabric/pull/333/checks |
Signed-off-by: Alan <fnlctrl@gmail.com>
denyeart
approved these changes
Dec 3, 2019
jyellick
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
curl and running a bash script from http is way too scary.
I ctrl+c-ed in shock the second I pasted the command into my terminal.
Why was it even http in the first place?
Additional details
Related issues