Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to update to v2 api #3529

Closed
wants to merge 6 commits into from
Closed

Conversation

SamYuan1990
Copy link
Contributor

Signed-off-by: Sam Yuan yy19902439@126.com

Type of change

  • Improvement (improvement to code, performance, etc)

Description

ref to #3464 (comment) and #3464 (comment) try to update go mod to v2

Additional details

Related issues

Signed-off-by: Sam Yuan <yy19902439@126.com>
@SamYuan1990 SamYuan1990 requested a review from a team as a code owner July 17, 2022 07:49
@SamYuan1990 SamYuan1990 marked this pull request as draft July 17, 2022 07:50
@SamYuan1990 SamYuan1990 mentioned this pull request Jul 17, 2022
Signed-off-by: Sam Yuan <yy19902439@126.com>
Signed-off-by: Sam Yuan <yy19902439@126.com>
Signed-off-by: Sam Yuan <yy19902439@126.com>
Signed-off-by: Sam Yuan <yy19902439@126.com>
Signed-off-by: Sam Yuan <yy19902439@126.com>
@SamYuan1990 SamYuan1990 marked this pull request as ready for review July 17, 2022 10:21
@SamYuan1990
Copy link
Contributor Author

@denyeart , please help with this pr, retry with unit test.

Copy link
Contributor

@yacovm yacovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should be doing this:

"github.com/hyperledger/fabric/v2/bccsp"
"github.com/hyperledger/fabric/v2/common/flogging"

Fabric core is not supposed to be imported by external projects as a go module. No one promises you anything about its packages not undergoing radical changes.

@SamYuan1990
Copy link
Contributor Author

I don't think we should be doing this:

"github.com/hyperledger/fabric/v2/bccsp"
"github.com/hyperledger/fabric/v2/common/flogging"

Fabric core is not supposed to be imported by external projects as a go module. No one promises you anything about its packages not undergoing radical changes.

Hi @yacovm , let's discuss at #3464 and for this PR. I am going to close it for now. As this pr is just a sample for open v2 modules. I want to have a single thread for discussion, instead of both PR and issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants