[FAB-17220] Dynamically build TLS config in Raft client handshake #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacovm
requested review from
ale-linux,
binhn,
C0rWin,
christo4ferris,
denyeart,
guoger,
jyellick,
kchristidis,
manish-sethi,
mastersingh24,
muralisrini and
sykesm
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mastersingh24
suggested changes
Dec 7, 2019
When we expand the root TLS CA in the channel config, *after* Raft membership has expanded with an OSN that is issed a certificate by a new TLS CA, the TLS client handshake uses the old root CA pool and as a result the added orderer cannot be reached by the existing ones, because their dialers reject its certificate. This change set builds a dynamic transport credentials that re-computes the TLS config in every TLS client handshake. Expanded an integration test to ensure this works. Change-Id: I6578ba49f16e14b97eb4eef4feccdecbfe1b7015 Signed-off-by: yacovm <yacovm@il.ibm.com>
mastersingh24
approved these changes
Dec 8, 2019
C0rWin
approved these changes
Dec 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we expand the root TLS CA in the channel config, after
Raft membership has expanded with an OSN that is issed a certificate
by a new TLS CA, the TLS client handshake uses the old root CA pool
and as a result the added orderer cannot be reached by the existing ones,
because their dialers reject its certificate.
This change set builds a dynamic transport credentials that
re-computes the TLS config in every TLS client handshake.
Expanded an integration test to ensure this works.
Change-Id: I6578ba49f16e14b97eb4eef4feccdecbfe1b7015
Signed-off-by: yacovm yacovm@il.ibm.com