Orderer v3: Remove system channel usage from integration tests: configtx #3905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tock-ibm
changed the title
And in the? |
yacovm
reviewed
Jan 11, 2023
| }, | ||
| } | ||
| config.SystemChannel = nil | ||
| config.Consensus.ChannelParticipationEnabled = true |
There was a problem hiding this comment.
we should eventually remove ChannelParticipationEnabled option since it's the only way... both here and in the orderer.yaml
There was a problem hiding this comment.
That is correct. I added a comment about that to the issue #3515
|
LGTM |
In the BFT case |
In configtx_test.go the channel creation TX part was removed. The channel is created without anchor peers and then all peers are turned into anchors. In the BFT case an app channel genesis block is generated, instead of a system channel genesis block. Signed-off-by: Yoav Tock <tock@il.ibm.com> Change-Id: Iac09bd9a2e0bc2440bf931b452da809fd7112d8a
yacovm
approved these changes
Jan 11, 2023
|
included in #3916 |
auto-merge was automatically disabled
January 12, 2023 07:11
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Remove system channel usage from integration tests: configtx
Related issues
Epic:#3511
Issue: #3515