Log peer config upon startup (#4118) #4122
Conversation
Log peer config upon startup. Also log peer environment variables to help troubleshoot peer config. Signed-off-by: David Enyeart <enyeart@us.ibm.com>
| logger.Infof("Peer config with combined core.yaml settings and environment variable overrides:\n%s", settingsYaml) | ||
|
|
||
| // Debug logging for peer environment variables | ||
| logger.Debugf("Environment variables:") |
There was a problem hiding this comment.
Sorry Dave, a nit: any specific reason why we use debug for this but info for the previous?
There was a problem hiding this comment.
I was debating this myself. In my opinion the exact peer config should be easily knowable by every user and support engineer hence Info level. This is consistent with what orderer node provides but for some reason peer never provided it.
The wider set of environment variables may be less important and potentially could leak sensitive information about the operating environment hence Debug level.
However, showing the environment variables will help a user or support engineer know whether a certain config setting came from core.yaml or from an environment variable override, so it is valuable information when troubleshooting a peer config.
I could go either way, WDYT?
|
A couple of notes.
|
|
I talked to celder628, he was talking about the effective config being printed at INFO level in the prior comment. He said that for the raw environment variables DEBUG is sufficient. So I think I'll keep the PR as-is. |
Log peer config upon startup.
Also log peer environment variables to help troubleshoot peer config.