[FAB-17176] Make decode hooks consistent in viperutil #424
Conversation
Signed-off-by: Tiffany Harris <tiffany.harris@ibm.com>
stephyee
requested review from
ale-linux,
binhn,
C0rWin,
christo4ferris,
denyeart,
guoger,
jyellick,
kchristidis,
manish-sethi,
mastersingh24,
muralisrini,
sykesm and
yacovm
as code owners
| continue | ||
| } | ||
| result = append(result, string(pem.EncodeToMemory(block))) | ||
| if block.Type != "CERTIFICATE" || len(block.Headers) != 0 { |
There was a problem hiding this comment.
I know this is like the original form, but - why do we really enforce a CERTIFICATE header here?
This is a generic viper util, so what if we have here a public key or a private key ? Then the header is different.
Also, i don't think that PEM parsing cares about header type at all - it only cares about -- BEGIN and -- END prefixes and ---- suffixes.
Served as "food for thought" only.
There was a problem hiding this comment.
Removing all of 'viperutil' is on our TODO list. I think we'd be better off without the magic (but not quite correct or consistent magic) around things like PEM blocks.
| continue | ||
| } | ||
| result = append(result, string(pem.EncodeToMemory(block))) | ||
| if block.Type != "CERTIFICATE" || len(block.Headers) != 0 { |
There was a problem hiding this comment.
Removing all of 'viperutil' is on our TODO list. I think we'd be better off without the magic (but not quite correct or consistent magic) around things like PEM blocks.
Signed-off-by: Tiffany Harris tiffany.harris@ibm.com
Type of change
Improvement to code
Related issues
https://jira.hyperledger.org/browse/FAB-17176