-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make AmMemberOf to use only the mspIDs in collection policy #4244
Conversation
return false, nil | ||
} | ||
if err := accessPolicy.EvaluateSignedData([]*protoutil.SignedData{&m.selfSignedData}); err != nil { | ||
if collectionPolicyConfig.GetSignaturePolicy() == nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe print in warning that this is nil?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix looks reasonable given we never added policy support for collections.
With the fix, I am not able to reproduce in local environment (basically the same test as the new integration test).
Signed-off-by: senthil <cendhu@gmail.com>
@Mergifyio backport release-2.5 |
✅ Backports have been created
|
https://github.com/Mergifyio backport release-2.2 |
✅ Backports have been created
|
Type of change
Description
#4229
Additional details
Related issues