[FAB-17279] Discovery supports collection level endorsement policies #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacovm
requested review from
ale-linux,
binhn,
C0rWin,
christo4ferris,
denyeart,
guoger,
jyellick,
kchristidis,
manish-sethi,
mastersingh24,
muralisrini and
sykesm
as code owners
This change set adapts discovery to take into account collection level endorsement policies. Since discovery supports multiple endorsement policies in a single invocation chain already (to support chaincode to chaincode writes), I changed the method that retrieves a single endorsement policy by chaincode namespace to retrieve a slice of several endorsement policies as well as extended the parameter to take into account the collections of the said chaincode. However, this change set has no effect on production since the discovery backend needs to change in order to actually fetch the collection specific endorsement policies if collections are specified. Change-Id: Id93911c9560a9db8f896a06f71c2ac07e801784a Signed-off-by: yacovm <yacovm@il.ibm.com>
C0rWin
approved these changes
Jan 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set adapts discovery to take into account collection level
endorsement policies.
Since discovery supports multiple endorsement policies in a single invocation
chain already (to support chaincode to chaincode writes), I changed the
method that retrieves a single endorsement policy by chaincode namespace
to retrieve a slice of several endorsement policies as well as extended the
parameter to take into account the collections of the said chaincode.
However, this change set has no effect on production since the discovery backend
needs to change in order to actually fetch the collection specific endorsement policies
if collections are specified.
Change-Id: Id93911c9560a9db8f896a06f71c2ac07e801784a
Signed-off-by: yacovm yacovm@il.ibm.com