Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error #4590

Merged
merged 1 commit into from Jan 8, 2024
Merged

fix error #4590

merged 1 commit into from Jan 8, 2024

Conversation

pfi79
Copy link
Contributor

@pfi79 pfi79 commented Jan 4, 2024

#4589

Analysed recent errors in gatway integration tests. There is one error everywhere (I hope it is the last one).
The problem is that after restarting orderer2 peer did not manage to reconnect to it because of backoff timeout.
I studied the logs and made it so that we don't send Submit until the peer connects to orderer2.

The mechanics of waiting are as follows:

  • looking for a string similar to "pickfirstBalancer: UpdateSubConnState: 0xc0006b4210, {TRANSIENT_FAILURE connection error: desc = "transport: Error while dialing: dial tcp 127.0.0.1:22005""
  • I get the address "0xc0006b4210" from the line.
  • I move the peer log cursor to the end.
  • After restarting the peer, I expect the line "0xc0006b4210, {READY". This is a part of the line pickfirstBalancer: UpdateSubConnState: 0xc0006b4210, {READY } - a sign that the connection is restored

For a test this is ok, but maybe in real work it will not work. Then I suggest someone to modify the file github.com/hyperledger/fabric/internal/pkg/gateway/registry.go . When selecting connections orderers should check the connection status and reconnect violently if necessary.

Signed-off-by: Fedor Partanskiy <pfi79@mail.ru>
@pfi79 pfi79 requested a review from a team as a code owner January 4, 2024 21:42
@pfi79 pfi79 changed the title fix error fix error #4589 Jan 4, 2024
@pfi79 pfi79 changed the title fix error #4589 fix error Jan 4, 2024
@C0rWin C0rWin merged commit 16856f9 into hyperledger:main Jan 8, 2024
14 checks passed
@pfi79 pfi79 deleted the fix-error-gateway-integration branch January 8, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants