BFT: A BFT synchronizer for smartbft #4695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tock-ibm
force-pushed
the
bft-sync-synchronizer
branch
from
31496ba
to
9fd9ea3
Compare
yacovm
reviewed
Feb 26, 2024
yacovm
reviewed
Feb 26, 2024
yacovm
reviewed
Feb 26, 2024
yacovm
reviewed
Feb 26, 2024
yacovm
reviewed
Feb 26, 2024
yacovm
reviewed
Feb 26, 2024
tock-ibm
force-pushed
the
bft-sync-synchronizer
branch
from
1a28d80
to
864103c
Compare
This commit provides a smartbft orderer with a BFTSynchronizer. The BFTSynchronizer is the default choice for a smartbft orderer. Signed-off-by: Yoav Tock <tock@il.ibm.com> Change-Id: I577c89309f469d077a9a1007d4b46fa70d7ed650
tock-ibm
force-pushed
the
bft-sync-synchronizer
branch
from
864103c
to
d1de467
Compare
Signed-off-by: Yoav Tock <tock@il.ibm.com> Change-Id: I3a17506964e9886e62dbb5b3e8bf8713345e43f9
tock-ibm
force-pushed
the
bft-sync-synchronizer
branch
from
d1de467
to
3ab04f6
Compare
yacovm
reviewed
Mar 4, 2024
|
|
||
| func NewSyncBuffer() *SyncBuffer { | ||
| return &SyncBuffer{ | ||
| blockCh: make(chan *common.Block, 10), |
There was a problem hiding this comment.
can we increase this buffer to 100 by default? and ideally this will be configurable. can we open an issue to make this configurable?
yacovm
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
A BFT synchronizer for smartbft
Related issues
Issue #4566