Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs reference version of hyperledger-fabric-ca from 1.4 to latest #4855

Merged
merged 1 commit into from May 13, 2024

Conversation

lir2002
Copy link
Contributor

@lir2002 lir2002 commented May 11, 2024

Last LTS version release-1.4 of hyperledger-fabric-ca was abandoned 4 years ago, but the successor version 1.5 has never been present as a candidate in the public docs page. Instead, the hyperledger-fabric-ca team only update latest version.

Type of change

  • Documentation update

Description

To adapt hyperledger-fabric-ca docs version, rename all references to hyperledger-fabric-ca version release-1.4 (if present) to latest, namely, change https://hyperledger-fabric-ca.readthedocs.io/en/release-1.4 to https://hyperledger-fabric-ca.readthedocs.io/en/latest. Because hyperledger-fabric-ca docs version release-1.4 hasn't been updated for 4 years, and the public maintaining version is latest.

Additional details

Updated docs is built out for review: https://ethan-li-fabric.readthedocs.io/en/latest/

Related issues

#4854

Last LTS version "1.4" of hyperledger-fabric-ca was dropped 4 years ago,
but the successor version "1.5" has never been present as a candidate in the public
docs page. Instead, the hyperledger-fabric-ca project only update "latest"
version.

Signed-off-by: Ethan Li <lir2002@gmail.com>
@lir2002 lir2002 requested review from a team as code owners May 11, 2024 01:33
@lir2002
Copy link
Contributor Author

lir2002 commented May 11, 2024

The Unit Tests failure has raised in many action runs in past few days. Error messages are similar when they failed. For example, in https://github.com/hyperledger/fabric/actions/runs/9015332707/job/24769864449 we can see

{"level":"warn","msg":"Could not synchronize with remote peers due to already at height of 100, returning state from local ledger"}
2024-05-09 09:46:20.078 UTC 07dd ERRO [test] VerifyConsenterSig -> Failed unmarshaling signature from 3: asn1: structure error: tags don't match (16 vs {class:0 tag:1 length:2 isCompound:false}) {optional:false explicit:false application:false private:false defaultValue:<nil> tag:<nil> stringType:0 timeType:0 set:false omitEmpty:false} Signature @2
2024-05-09 09:46:20.079 UTC 07de ERRO [test] VerifyConsenterSig -> Offending signature Msg: AQID
2024-05-09 09:46:20.079 UTC 07df ERRO [test] VerifyConsenterSig -> Offending signature Value: AQID
2024-05-09 09:46:20.079 UTC 07e0 WARN [test] verifySignatureIsBoundToProposal -> Expected consenter metadata  but got CAIQAQ== in proposal
2024-05-09 09:46:20.080 UTC 07e1 ERRO [test] verifySignatureIsBoundToProposal -> Expected block header MEcCARQEICwHuNy5d53xZKCmak0amtoYPgOBmEKzrF5TsDysFKEfBCBJ12k2arQJvHBiP+/saiZsdQVbD3F553flq4OAgq2JYQ== but got 
2024-05-09 09:46:20.082 UTC 07e2 WARN [test] verifySignatureIsBoundToProposal -> got malformed proposal: bad payload and metadata tuple: asn1: structure error: tags don't match (16 vs {class:0 tag:1 length:2 isCompound:false}) {optional:false explicit:false application:false private:false defaultValue:<nil> tag:<nil> stringType:0 timeType:0 set:false omitEmpty:false} ByteBufferTuple @2
2024-05-09 09:46:20.082 UTC 07e3 WARN [test] verifySignatureIsBoundToProposal -> got malformed proposal: proposal payload cannot be nil
FAIL

Copy link
Contributor

@denyeart denyeart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, good catch!

@denyeart denyeart enabled auto-merge (rebase) May 13, 2024 13:16
@denyeart denyeart merged commit cc688f9 into hyperledger:main May 13, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants