Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chaincode persistence uses period separator #492

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

sykesm
Copy link
Contributor

@sykesm sykesm commented Jan 13, 2020

  • Use a period separator between the chaincode label and hash
  • Update chaincode store file matcher to explicitly look for files with
    a suffix of exactly 64 hex characters + ".tar.gz" to reduce depenency
    on special characters in the label.

Related Issue

FAB-17315

- Use a period separator between the chaincode label and hash
- Update chaincode store file matcher to explicitly look for files with
  a suffix of exactly 64 hex characters + ".tar.gz" to reduce depenency
  on special characters in the label.

FAB-17315

Change-Id: I9c14ac0a5b7adaa4c5ca50a487e1fba1d87f8b4b
Signed-off-by: Matthew Sykes <sykesmat@us.ibm.com>
@sykesm sykesm requested a review from a team as a code owner January 13, 2020 19:17
@sykesm sykesm requested a review from jyellick January 13, 2020 20:00
Copy link
Contributor

@mastersingh24 mastersingh24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but @jyellick should take a look as well

@jyellick jyellick merged commit b578a96 into hyperledger:master Jan 15, 2020
@sykesm sykesm deleted the FAB-17315 branch January 29, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants