[FAB-17192] Add unit tests for executeCommitter and commitUpdates #621
Conversation
DereckLuo
force-pushed
the
FAB-17192
branch
2 times, most recently
from
bc37567
to
4efe7fb
Compare
|
|
||
| err = db.executeCommitter(committers) | ||
| assert.NoError(t, err) | ||
|
|
There was a problem hiding this comment.
can you add a check for key/values finally committed in the db
There was a problem hiding this comment.
@manish-sethi check has been added, thanks.
| assert.EqualError(t, err, "error handling CouchDB request. Error:bad_request, Status Code:400, Reason:`docs` parameter must be an array.") | ||
| } | ||
|
|
||
| func TestCommitUpdates(t *testing.T) { |
There was a problem hiding this comment.
One of the tasks of commitUpdate() function is to update the revision present in the cache. This is done by maintaining the newly created revision in the cacheKVs map present in the committer object. It would be good to add a test to check whether the revision is being updated correctly. We can do the following to check that:
- add the key and the empty revision (as the key is new) to the cacheKVs map in the committer object.
- once the committer completes its execution, it would update the cacheKVs with the assigned revision for the key.
- check whether the revision has been changed in the cacheKVs map.
There was a problem hiding this comment.
thanks for the review. new test cases has been added.
| } | ||
| err = committer.commitUpdates() | ||
| assert.NoError(t, err) | ||
| assert.NotEmpty(t, committer.cacheKVs["key2"]) |
There was a problem hiding this comment.
One minor change is required but the rest looks good to me.
assert.NotEmpty(t, committer.cacheKVs["key2"]) would always be true as per line 294. The main thing that changes after running committer.commitUpdates() is the cacheKVs["key2"].AdditionalInfo which holds the revision.
Replace line 299 with assert.NotEmpty(t, committer.cacheKVs["key2"].AdditionalInfo) Here, cacheKVs["key2"].AdditionalInfo would be non-empty after running committer.commitUpdates() but empty before that.
- Added statecouchdb unit test for executeCommitter and commitUpdates functions. Signed-off-by: Chongxin Luo <Chongxin.Luo@ibm.com>
|
Thanks @DereckLuo and @cendhu for additional review. |
Signed-off-by: Chongxin Luo Chongxin.Luo@ibm.com
Type of change
Description
Additional details
Related issues
FAB-17192