Remove BCCSP Utilities #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cendhu
requested changes
Mar 28, 2020
cendhu
reviewed
Mar 28, 2020
Removes the multiple utility files and functions for checking if a dir exists and simply performs the check in original calling function Signed-off-by: Brett Logan <brett.t.logan@ibm.com>
Pushes the clone commands into the caller and removes the cloning utility Signed-off-by: Brett Logan <brett.t.logan@ibm.com>
Pushes the DERToX509Certificate functionality into the caller as it was simply a wrapper for a direct call to x509.ParseCertificate Signed-off-by: Brett Logan <brett.t.logan@ibm.com>
sykesm
reviewed
Mar 28, 2020
sykesm
reviewed
Mar 28, 2020
sykesm
reviewed
Mar 28, 2020
sykesm
approved these changes
Mar 29, 2020
denyeart
pushed a commit
that referenced
this pull request
Mar 29, 2020
Signed-off-by: Brett Logan <brett.t.logan@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a bunch of "utilities" in the BCCSP package and pushes the very simplistic code into the calling functions