Set default keepalive options for peer clients #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest version of grpc now sets the default client keepalive time to 10 seconds. Prior to this, if the timeout was set to 0, grpc actually used an infinite timeout by default which effectively meant no keepalives were ever sent. Since it now sets the default to 10 seconds and the server permitted timeout is actual set to 20 seconds, we now see disconnects for requests taking > 20 secs as the client is now violating the policy. Signed-off-by: Gari Singh <gari.r.singh@gmail.com>
yacovm
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
The latest version of grpc now sets the default
client keepalive time to 10 seconds. Prior to this,
if the timeout was set to 0, grpc actually used an
infinite timeout by default which effectively meant
no keepalives were ever sent. Since it now sets the
default to 10 seconds and the server permitted timeout is
actual set to 20 seconds, we now see disconnects for
requests taking > 20 secs as the client is now violating
the policy.
Related issues
FAB-17706
#930
Signed-off-by: Gari Singh gari.r.singh@gmail.com