Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Goreleaser Job #250

Merged
merged 6 commits into from
Sep 18, 2023
Merged

Fix Goreleaser Job #250

merged 6 commits into from
Sep 18, 2023

Conversation

nguyer
Copy link
Contributor

@nguyer nguyer commented Jul 5, 2023

Resolves #249

Also updates the goreleaser action to v4

Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@nguyer
Copy link
Contributor Author

nguyer commented Jul 5, 2023

Successfully produced "correctly" named archives in this test release: https://github.com/hyperledger/firefly-cli/releases/tag/v1.2.2-alpha.3

Successful GitHub workflow run: https://github.com/hyperledger/firefly-cli/actions/runs/5468837574

Copy link
Contributor

@matthew1001 matthew1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is it worth updating actions/setup-go to v4 at the same time?

Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@shorsher
Copy link
Member

LGTM. I'm assuming goreleaser is failing here because this hasn't been merged yet?

@nguyer nguyer merged commit ba99502 into main Sep 18, 2023
10 of 12 checks passed
@nguyer nguyer deleted the goreleaser branch September 18, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Builds failing due to goreleaser deprecation/removal of replacements
4 participants