Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding linter in Makefile to catch lint issues #98

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

apoorvam1
Copy link
Contributor

Signed-off-by: Apoorva Mahabaleshwara apoorvambhat@gmail.com

Signed-off-by: Apoorva Mahabaleshwara <apoorvambhat@gmail.com>
Copy link
Contributor

@nguyer nguyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thank you! We will want to add lint to the all section after we fix all the lint errors, but I'll merge this as-is for now, and we can get started on fixing all the problems.

@nguyer nguyer merged commit 783dd5d into hyperledger:main Oct 1, 2021
@nguyer
Copy link
Contributor

nguyer commented Oct 12, 2021

This resolves #42

I will open another issue to track making changes to the code to satisfy the linting rules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants