Remove "data" parameter for token pools

With the introduction of a separate trackingId field, there's no longer any useful data to be passed here. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
hyperledger · Nov 4, 2021 · fe49c0a · fe49c0a
1 parent 74cd053
commit fe49c0a
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 14 deletions.
diff --git a/src/tokens/tokens.interfaces.ts b/src/tokens/tokens.interfaces.ts
@@ -92,10 +92,6 @@ export class TokenPool {
   @ApiProperty({ description: poolConfigDescription })
   @IsOptional()
   config?: any;
-
-  @ApiProperty()
-  @IsOptional()
-  data?: string; // TODO: remove
 }
 
 export class TokenBalanceQuery {
@@ -191,9 +187,6 @@ class tokenEventBase {
 export class TokenPoolEvent extends tokenEventBase {
   @ApiProperty()
   standard: string;
-
-  @ApiProperty()
-  data?: string; // TODO: remove
 }
 
 export class TokenTransferEvent extends tokenEventBase {

diff --git a/src/tokens/tokens.service.ts b/src/tokens/tokens.service.ts
@@ -94,7 +94,6 @@ export class TokensService {
   async createPool(dto: TokenPool): Promise<AsyncResponse> {
     const dataToPack: PackedTokenData = {
       trackingId: dto.trackingId,
-      data: dto.data, // TODO: remove
     };
     const response = await lastValueFrom(
       this.http.post<EthConnectAsyncResponse>(
@@ -243,7 +242,6 @@ class TokenListener implements EventListener {
         type: unpackedId.isFungible ? TokenType.FUNGIBLE : TokenType.NONFUNGIBLE,
         operator: data.operator,
         trackingId: unpackedData.trackingId,
-        data: unpackedData.data, // TODO: remove
         transaction: {
           blockNumber: event.blockNumber,
           transactionIndex: event.transactionIndex,

diff --git a/test/app.e2e-spec.ts b/test/app.e2e-spec.ts
@@ -140,7 +140,6 @@ describe('AppController (e2e)', () => {
       type: TokenType.FUNGIBLE,
       requestId: 'op1',
       trackingId: 'tx1',
-      data: 'test',
       operator: IDENTITY,
     };
     const response: EthConnectAsyncResponse = {
@@ -156,7 +155,7 @@ describe('AppController (e2e)', () => {
     expect(http.post).toHaveBeenCalledWith(
       `${INSTANCE_URL}/create`,
       {
-        data: '0x7b22747261636b696e674964223a22747831222c2264617461223a2274657374227d',
+        data: '0x7b22747261636b696e674964223a22747831227d',
         is_fungible: true,
       },
       {
@@ -172,7 +171,6 @@ describe('AppController (e2e)', () => {
   it('Create non-fungible pool', async () => {
     const request: TokenPool = {
       type: TokenType.NONFUNGIBLE,
-      data: 'test',
       operator: '0xabc',
     };
     const response: EthConnectAsyncResponse = {
@@ -188,7 +186,7 @@ describe('AppController (e2e)', () => {
     expect(http.post).toHaveBeenCalledWith(
       `${INSTANCE_URL}/create`,
       {
-        data: '0x7b2264617461223a2274657374227d',
+        data: '0x7b7d',
         is_fungible: false,
       },
       {
@@ -377,7 +375,6 @@ describe('AppController (e2e)', () => {
         expect(message).toEqual(<WebSocketMessage>{
           event: 'token-pool',
           data: <TokenPoolEvent>{
-            data: 'test',
             trackingId: 'tx1',
             standard: 'ERC1155',
             poolId: 'F1',