Extract a clearer IERC1155Factory interface #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awrichar
requested review from
peterbroadhurst,
nguyer and
shorsher
as code owners
awrichar
force-pushed
the
factory
branch
7 times, most recently
from
3b2e847
to
b5ca47f
Compare
Split the concept of a "pool factory" (which encompasses a single method and
a single event) away from all of the other opinionated spellings in the
IERC1155MixedFungible interface.
The parameters of the TokenPoolCreation event have also been altered, but
both the old and new parameters will be parsed by the listener.
This also removes some remaining reliance on "instancePath", which is now
deprecated and generally not set ("contractAddress" is favored instead).
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the concept of a "pool factory" (which encompasses a single method and a single event) away from all of the other opinionated spellings in the IERC1155MixedFungible interface.
The parameters of the TokenPoolCreation event have also been altered, but both the old and new parameters will be parsed by the listener.
This also removes some remaining reliance on "instancePath", which is now deprecated and generally not set ("contractAddress" is favored instead).