Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated FFI does not have "pathname" populated #1422

Closed
awrichar opened this issue Nov 8, 2023 · 0 comments · Fixed by #1423
Closed

Generated FFI does not have "pathname" populated #1422

awrichar opened this issue Nov 8, 2023 · 0 comments · Fixed by #1423

Comments

@awrichar
Copy link
Contributor

awrichar commented Nov 8, 2023

FireFly helps to de-duplicate overloaded methods in an ABI by assigning a "pathname" to each method, if the method name is not unique.

This logic is part of the ResolveFFI method, and is currently only run when an interface is created/saved. It would be easy and beneficial to also run this validation during GenerateFFI, allowing you to preview the generated pathnames instead of leaving them with empty strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant