xdc + zksync #1114
Merged
xdc + zksync #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aznrayizzle
requested review from
peterbroadhurst,
nguyer,
awrichar,
shorsher and
nickgaski
as code owners
shorsher
reviewed
Dec 9, 2022
docs/tutorials/chains/xdc_testnet.md
Outdated
| ] | ||
| ``` | ||
|
|
||
| XDC has changed their wallet address [prefix] (https://medium.com/xinfin/xinfin-releases-new-address-prefix-starting-with-xdc-75750a444f77) to start with "xdc" instead of "0x". |
There was a problem hiding this comment.
think you need to remove the space between [prefix] and the link
shorsher
reviewed
Dec 9, 2022
| - Connect to an ethereum network | ||
| - Use the `evmconnect` blockchain connector | ||
| - Use an remote RPC node. This will create a signer locally, so that our signing key never leaves the development machine. | ||
| - See the list of providers for zkSync [docs](https://v2-docs.zksync.io/dev/fundamentals/testnet.html). For this tutorial we will use https://zksync2-testnet.zksync.dev |
There was a problem hiding this comment.
Should we change the styling of the https://zksync2-testnet.zksync.dev link to make it appear different from non-link text.
aznrayizzle
force-pushed
the
xdczksync
branch
from
8535e78
to
0efc587
Compare
Codecov Report
@@ Coverage Diff @@
## main #1114 +/- ##
==========================================
+ Coverage 99.93% 99.97% +0.04%
==========================================
Files 302 302
Lines 19426 19426
==========================================
+ Hits 19414 19422 +8
+ Misses 9 4 -5
+ Partials 3 0 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: aznrayizzle <ray.chen@kaleido.io>
aznrayizzle
force-pushed
the
xdczksync
branch
from
0efc587
to
028d04f
Compare
shorsher
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add xdc + zkSync tutorials