Default token pool interfaceFormat to empty string #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading a NULL value into a Go string is unsupported. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
awrichar
requested review from
peterbroadhurst,
nguyer and
shorsher
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1142 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 303 303
Lines 19799 19799
=========================================
Hits 19799 19799 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nguyer
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading a NULL value into a Go string is unsupported.
Default this column to
''so that pre-existing token pools receive that value instead of aNULL.Note that this is an alteration to a migration file added in #1123, so wouldn't be executed by any installation that has already picked up that change. Since it hasn't yet been released, this shouldn't cause any problems.