Fix panic on webhooks without messages #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
nguyer
requested review from
peterbroadhurst,
awrichar and
shorsher
as code owners
awrichar
approved these changes
Jan 24, 2023
awrichar
reviewed
Jan 26, 2023
| default: | ||
| // Otherwise just send the first object directly | ||
| case len(allData) == 1: | ||
| // Just send the first object directly | ||
| req.r.SetBody(firstData) |
There was a problem hiding this comment.
In retrospect, Codecov is saying that this line is now missing coverage...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1155
This PR changes the behavior of webhook callbacks in several ways:
replyis specified on the subscription it no longer panics if there is no Message on the event (such as is the case with custom contract events)withDatais specified subscription, but no Message is on the event, the event payload itself will still be sentThis means that subscriptions can be setup with either the
replyandwithDatafields set (or both) and still use the same subscription for custom contract events as well.