Call Features() getter to read DB provider features #1197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking into #1199 (originally due to #1196) it appears that we are referencing the
SQLCommon.features
struct field expecting it to have the features of the DB provider, but with the refactoring that took place under #1110 theSQLCommon.features
field is actually populated by the DB provider. That's because there's now also aDatabase.features
struct field infirefly-common
which is the one that's actually been populated.In this PR I've removed the
SQLCommon.features
field and where we try to read from it today, used instead the newFeatures()
getter that I've added underfirefly-common
PR hyperledger/firefly-common#49This PR will remain in draft until hyperledger/firefly-common#49 is approved and we have a new release of(firefly-common v1.2.3 now released and pulled in under the latest commit)firefly-common
to pull in.