Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging of blockchain event inserts #1215

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

awrichar
Copy link
Contributor

@awrichar awrichar commented Mar 9, 2023

This is causing blockchain event inserts to incorrectly be logged as message inserts.

@awrichar awrichar force-pushed the blockchainevent branch 2 times, most recently from 888a615 to b089c01 Compare March 10, 2023 05:16
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2023

Codecov Report

Merging #1215 (888a615) into main (9342b5c) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 888a615 differs from pull request most recent head 756e192. Consider uploading reports for the commit 756e192 to get more accurate results

@@            Coverage Diff            @@
##              main     #1215   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          305       305           
  Lines        20057     20075   +18     
=========================================
+ Hits         20057     20075   +18     
Impacted Files Coverage Δ
internal/database/sqlcommon/sqlcommon.go 100.00% <ø> (ø)
cmd/firefly.go 100.00% <100.00%> (ø)
internal/assets/token_approval.go 100.00% <100.00%> (ø)
internal/assets/token_transfer.go 100.00% <100.00%> (ø)
internal/batch/batch_processor.go 100.00% <100.00%> (ø)
internal/broadcast/manager.go 100.00% <100.00%> (ø)
internal/database/sqlcommon/batch_sql.go 100.00% <100.00%> (ø)
internal/database/sqlcommon/blob_sql.go 100.00% <100.00%> (ø)
internal/database/sqlcommon/data_sql.go 100.00% <100.00%> (ø)
internal/database/sqlcommon/event_sql.go 100.00% <100.00%> (ø)
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Copy link
Contributor

@nguyer nguyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks more correct than it used to be.

@nguyer nguyer merged commit 1a5a59e into hyperledger:main Mar 10, 2023
@nguyer nguyer deleted the blockchainevent branch March 10, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants