Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that when we broadcast we use the org identity, not the default NS identity #1223

Merged
merged 2 commits into from
Mar 17, 2023

Conversation

peterbroadhurst
Copy link
Contributor

Since 1.1 we've had both an org identity (required for mulit-party), and a default namespace identity (optional).
The code for definition broadcasts must use the org identity for that broadcast to be accepted, but the code was using the same priority as generic API calls - which use the NS default identity in preference.

This PR updates that so it's always the org identity, and the call will not fall-back to the default.

Found this while discussing #1222 and hence in a PR chain with that change

…tion

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@codecov-commenter
Copy link

Codecov Report

Merging #1223 (14ee3a9) into main (35319a2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1223   +/-   ##
=======================================
  Coverage   99.99%   99.99%           
=======================================
  Files         306      306           
  Lines       20107    20112    +5     
=======================================
+ Hits        20105    20110    +5     
  Misses          1        1           
  Partials        1        1           
Impacted Files Coverage Δ
internal/events/event_manager.go 100.00% <ø> (ø)
internal/definitions/sender.go 100.00% <100.00%> (ø)
internal/events/token_pool_created.go 100.00% <100.00%> (ø)
internal/tokens/fftokens/fftokens.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nguyer nguyer merged commit f6c590c into hyperledger:main Mar 17, 2023
@nguyer nguyer deleted the org-broadcast branch March 17, 2023 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants