Do not reject messages from an unrecognized identity #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awrichar
requested review from
peterbroadhurst,
nguyer and
shorsher
as code owners
awrichar
commented
Mar 17, 2023
| return false, nil // This is not retryable. skip this batch | ||
| // Only private messages, or root org broadcasts can have an unregistered identity | ||
| l.Warnf("Skipping message '%s'. Author '%s' could not be resolved: %s", msg.Header.ID, msg.Header.Author, err) | ||
| return core.ActionWait, nil // Wait in case the identity is resolved later |
There was a problem hiding this comment.
This is the material change that solves the bug. Everything else is just cleanup to make this possible.
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Because batch downloads happen asynchronously on download manager, it's possible that the details for an identity claim may be downloaded after other things created by that identity. Instead of flatly rejecting all messages from an unknown identity, leave them in pending state so that they can be unstuck by a later rewind. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Codecov Report
@@ Coverage Diff @@
## main #1224 +/- ##
==========================================
- Coverage 99.99% 99.93% -0.06%
==========================================
Files 306 306
Lines 20115 20112 -3
==========================================
- Hits 20113 20098 -15
- Misses 1 13 +12
Partials 1 1
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
peterbroadhurst
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because batch downloads happen asynchronously on download manager, it's possible
that the details for an identity claim may be downloaded after other things
created by that identity.
Instead of flatly rejecting all messages from an unknown identity, leave them
in pending state so that they can be unstuck by a later rewind.
Fixes #1221