-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an indxed column and simple query API for distinct sub-paths #1236
Conversation
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Codecov Report
@@ Coverage Diff @@
## main #1236 +/- ##
==========================================
+ Coverage 99.91% 99.97% +0.05%
==========================================
Files 306 307 +1
Lines 20135 20189 +54
==========================================
+ Hits 20117 20183 +66
+ Misses 15 3 -12
Partials 3 3
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
One question on this... when I upload a blob today, I don't have the option to give it a name. It looks like we calculate the path based off the name, but I didn't see anything that adds the ability to set the name in this PR when doing a multi-part file upload. I could very well just be overlooking something though? |
Let me find the semantics for setting that name, which as you say are unchanged in this PR... |
Here we go: #381 (pointing to FIR 3) |
Okay. I re-read over that FIR (thanks for digging that up). Maybe it's just that the Swagger doesn't explain that this is possible to set? If I want to specify the name, do I need to send JSON and the file? I'm not sure how one would do that? There are a few fields exposed on the Swagger UI for things that can be set. Do we need to add |
The Swagger contains the details to the extent it can I think (without us building docs for a bigger Markdown/HTML multi-line documentation on complex APIs beyond Swagger's capabilities to document at the field level). I'm happy to work on something related to instructions for using the |
I raised #1241 to decouple the investigation there |
Yep, I'm happy for those enhancements to be a separate PR. I don't think it's urgent, so whenever we get to it. It just seems non-obvious how a user would use the new functionality here though, so as long as that gap gets closed at some point, I'm happy to merge this. |
Fixes #1227
blob_path
column /blob.path
JSON field for the path/
prefixing on these paths, without requiring the name to include a/
prefix