Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for evmconnect's "execution reverted" error code #1249

Merged
merged 3 commits into from
Apr 4, 2023

Conversation

awrichar
Copy link
Contributor

When querying network version, look for the unique error codes returned by either ethconnect or evmconnect.

Partial fix for #1245
Depends on hyperledger/firefly-evmconnect#67

When querying network version, look for the unique error codes returned by
either ethconnect or evmconnect.

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2023

Codecov Report

Merging #1249 (c4d7c22) into main (a7226c9) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1249   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files         308      308           
  Lines       20555    20555           
=======================================
  Hits        20549    20549           
  Misses          4        4           
  Partials        2        2           
Impacted Files Coverage Δ
internal/blockchain/ethereum/ethereum.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@awrichar
Copy link
Contributor Author

awrichar commented Apr 3, 2023

Looks like another instance of unit test failure/race condition as noted in #1250

Also some unexplained E2E failures... They passed locally, so it feels like this may be yet another intermittent issue.

Copy link
Contributor

@nguyer nguyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving my approval, with the assumption that test issues will get resolved.

@awrichar
Copy link
Contributor Author

awrichar commented Apr 3, 2023

The failing E2E tests seem to be getting a "success" receipt for operations and then later setting them back to "pending".

From container-logs-TestEthereumMultipartyE2ESuite--evmconnect-postgres-erc20_erc721.zip:

�[34mfirefly_core_0_1  |�[0m [2023-04-03T19:07:12.798Z]  INFO Executing blockchain_pin_batch operation 3d50e255-8a76-4f0b-90e7-a8057742d03a via handler MultipartyManager d=pinned_private ns=default opcache=gHUVhbnP p=did:firefly:org/org_2c04ae|0x7687f51f767037399c2d293808601db9... pid=1 role=batchmgr
�[34mfirefly_core_0_1  |�[0m [2023-04-03T19:07:12.814Z]  INFO Received operation update: status=Succeeded request=default:3d50e255-8a76-4f0b-90e7-a8057742d03a message= pid=1 proto=fftokens role=event-loop
�[34mfirefly_core_0_1  |�[0m [2023-04-03T19:07:12.814Z] DEBUG fftokens updating operation default:3d50e255-8a76-4f0b-90e7-a8057742d03a status=Succeeded ns=default pid=1
�[34mfirefly_core_0_1  |�[0m [2023-04-03T19:07:12.814Z]  INFO Received operation update: status=Succeeded request=default:3d50e255-8a76-4f0b-90e7-a8057742d03a tx=0x7b249c2f47faec3ae604cec512815da8dbed834801c26bf3432e30e66da7e748 message= pid=1 proto=ethereum role=event-loop
�[34mfirefly_core_0_1  |�[0m [2023-04-03T19:07:12.815Z] DEBUG ethereum updating operation default:3d50e255-8a76-4f0b-90e7-a8057742d03a status=Succeeded ns=default pid=1
�[34mfirefly_core_0_1  |�[0m [2023-04-03T19:07:12.817Z] DEBUG ethereum updating operation default:3d50e255-8a76-4f0b-90e7-a8057742d03a status=Pending ns=default pid=1
�[34mfirefly_core_0_1  |�[0m [2023-04-03T19:07:12.818Z] DEBUG Operation update 'default:3d50e255-8a76-4f0b-90e7-a8057742d03a' from 'fftokens' ignored, as it does not match operation source 'ethereum' dbtx=6ou1vsUv ns=default pid=1

@awrichar
Copy link
Contributor Author

awrichar commented Apr 3, 2023

E2E failures seem to be persistent. Opened #1256.

@awrichar awrichar merged commit 5f8d34d into hyperledger:main Apr 4, 2023
14 checks passed
@awrichar awrichar deleted the reverted branch April 4, 2023 15:37
@awrichar awrichar mentioned this pull request Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants