-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for evmconnect's "execution reverted" error code #1249
Conversation
When querying network version, look for the unique error codes returned by either ethconnect or evmconnect. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Codecov Report
@@ Coverage Diff @@
## main #1249 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 308 308
Lines 20555 20555
=======================================
Hits 20549 20549
Misses 4 4
Partials 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Looks like another instance of unit test failure/race condition as noted in #1250 Also some unexplained E2E failures... They passed locally, so it feels like this may be yet another intermittent issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving my approval, with the assumption that test issues will get resolved.
The failing E2E tests seem to be getting a "success" receipt for operations and then later setting them back to "pending". From
|
E2E failures seem to be persistent. Opened #1256. |
When querying network version, look for the unique error codes returned by either ethconnect or evmconnect.
Partial fix for #1245
Depends on hyperledger/firefly-evmconnect#67