Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated config #1289

Merged
merged 4 commits into from
Apr 28, 2023

Conversation

EnriqueL8
Copy link
Contributor

  • Remove deprecated config for blockchain, tokens, factory, database, dex and shared storaged config

- Remove deprecated config for blockchain, tokens, factory, database, dex and shared storaged config

Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was discussed in Discord with contributors, including @awrichar

Marking migration consideration to ensure it's included in the V1.3 migration notes when they are built.

Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
@peterbroadhurst
Copy link
Contributor

peterbroadhurst commented Apr 25, 2023

I see you've got a swagger mismatch:

        	Test:       	TestDiffSwaggerYAML
        	Messages:   	The swagger generated by the code did not match the swagger.yml file in git. Did you forget to run `make reference`?

Currently until #1233 is merged, if you build make reference locally with Go 1.19/1.20 it generates a different set of YAML fields to the build that runs in Github actions with 1.18. So you might need to check in your local dev env you run make reference with Go 1.18.

Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2023

Codecov Report

Merging #1289 (008aa86) into main (5a78f15) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #1289   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          308       308           
  Lines        20723     20671   -52     
=========================================
- Hits         20723     20671   -52     
Impacted Files Coverage Δ
internal/namespace/config.go 100.00% <ø> (ø)
internal/namespace/manager.go 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@peterbroadhurst
Copy link
Contributor

Noticed a coverage drop - so popped in an extra commit to help this close out

@peterbroadhurst peterbroadhurst merged commit e239a5c into hyperledger:main Apr 28, 2023
14 checks passed
@peterbroadhurst peterbroadhurst deleted the deprecate_config branch April 28, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants