feat: background start for connector plugins #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
There was a problem hiding this comment.
This looks great @EnriqueL8!
Couple of minor suggestions from patterns we've found helpful in other code, and a query on goroutines.
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
|
There seems to be flaky test I introduced - will fix that |
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Codecov Report
@@ Coverage Diff @@
## main #1315 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 310 310
Lines 20960 21040 +80
=========================================
+ Hits 20960 21040 +80
|
EnriqueL8
requested review from
nguyer,
awrichar,
shorsher and
nickgaski
as code owners
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
| e.backgroundStart = e.ethconnectConf.GetBool(EthconnectBackgroundStart) | ||
| if e.backgroundStart { | ||
| e.backgroundRetry = &retry.Retry{ | ||
| InitialDelay: fftypes.ParseToDuration(defaultBackgroundInitialDelay), |
There was a problem hiding this comment.
I think these should be config settings @EnriqueL8
There was a problem hiding this comment.
Okay, I did think about it but wasn't 100% sure :) - will do it!
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.