log: add debug logs for webhook #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
EnriqueL8
requested review from
peterbroadhurst,
nguyer,
awrichar and
shorsher
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1380 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 321 321
Lines 23108 23111 +3
=======================================
+ Hits 23106 23109 +3
Misses 1 1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
nguyer
reviewed
Jul 31, 2023
internal/events/webhooks/webhooks.go
Outdated
| @@ -403,7 +402,7 @@ func (wh *WebHooks) attemptRequest(ctx context.Context, sub *core.Subscription, | |||
| Status: resp.StatusCode(), | |||
| Headers: fftypes.JSONObject{}, | |||
| } | |||
| // log.L(wh.ctx).Infof("Webhook<- %s %s event %s on subscription %s returned %d", req.method, req.url, event.ID, sub.ID, res.Status) | |||
| log.L(wh.ctx).Infof("Webhook<- %s %s on subscription %s returned %d", req.method, req.url, sub.ID, res.Status) | |||
There was a problem hiding this comment.
Should this be INFO or DEBUG level? Looks like the corresponding log message above is DEBUG.
There was a problem hiding this comment.
Sure happy to change it to DEBUG
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
EnriqueL8
commented
Jan 17, 2024
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
nguyer
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase log coverage for webhooks as it's quite helpful when debugging