Prevent inserting token transfers with invalid blockchain event refs #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an existing blockchain event is found, be sure to look up and use the existing ID when inserting token transfers/approvals. Fixes hyperledger#1385 Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
awrichar
requested review from
peterbroadhurst,
nguyer and
shorsher
as code owners
awrichar
commented
Aug 1, 2023
|
|
||
| err := em.maybePersistBlockchainEvent(em.ctx, ev, nil) | ||
| assert.NoError(t, err) | ||
| assert.Equal(t, existingID, ev.ID) |
There was a problem hiding this comment.
This (important) test condition got lost in a previous PR. Making this true again is really the singular focus of this PR.
nguyer
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an existing blockchain event is found, be sure to look up and use the existing ID when inserting token transfers/approvals.
Fixes #1385