Fix SQL migration conflict and coverage gaps #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1401 +/- ##
==========================================
+ Coverage 99.96% 99.98% +0.01%
==========================================
Files 316 316
Lines 22147 22147
==========================================
+ Hits 22139 22143 +4
+ Misses 4 2 -2
+ Partials 4 2 -2
|
awrichar
reviewed
Sep 15, 2023
test/e2e/e2e.log
Outdated
There was a problem hiding this comment.
Don't think this was supposed to be checked in?
awrichar
reviewed
Sep 15, 2023
| @@ -163,8 +163,8 @@ func (suite *FabricContractTestSuite) TestE2EContractEvents() { | |||
| assert.NoError(suite.T(), err) | |||
| assert.Equal(suite.T(), assetName, res.(map[string]interface{})["name"]) | |||
|
|
|||
| suite.testState.client1.DeleteContractListener(suite.T(), subs[0].ID) | |||
| subs = suite.testState.client1.GetContractListeners(suite.T(), suite.testState.startTime) | |||
| assert.Equal(suite.T(), 0, len(subs)) | |||
There was a problem hiding this comment.
Did you mean to leave this commented out?
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
This was referenced Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had two PRs get merged separately that used the same migration number. This PR also fixes two small gaps in unit test coverage.