Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check enabled for organization creation in non-multiparty system #1405

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

arinddas
Copy link
Contributor

Fix for #1404

Added checks on /firefly/internal/apiserver/route_post_new_organization.go
Updated the test file /firefly/internal/apiserver/route_post_new_organization_test.go

Test result:

Running tool: /usr/local/go/bin/go test -timeout 10s -run ^TestNewOrganization$ github.com/hyperledger/firefly/internal/apiserver

=== RUN   TestNewOrganization
time="2023-09-21T22:20:26+05:30" level=info msg="--> POST /api/v1/network/organizations" httpreq=ZlrSSWSy
time="2023-09-21T22:20:26+05:30" level=info msg="<-- POST /api/v1/network/organizations [202] (1.67ms)" httpreq=ZlrSSWSy
--- PASS: TestNewOrganization (0.25s)
PASS
ok      github.com/hyperledger/firefly/internal/apiserver       0.493s

Signed-off-by: Arindam Dasgupta <arinddas@in.ibm.com>
@nguyer
Copy link
Contributor

nguyer commented Sep 21, 2023

The linter is expecting the year to be changed in the header in this file since it was updated this year:

// Copyright © 2022 Kaleido, Inc.

…ization creation in non-multiparty system

Signed-off-by: Arindam Dasgupta <arinddas@in.ibm.com>
@arinddas
Copy link
Contributor Author

Thank you @nguyer. I have modified the year on header portion of file.

@codecov-commenter
Copy link

Codecov Report

Merging #1405 (a17a296) into main (6cc1c67) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1405   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         321      321           
  Lines       22957    22960    +3     
=======================================
+ Hits        22953    22956    +3     
  Misses          2        2           
  Partials        2        2           
Files Changed Coverage Δ
internal/apiserver/route_post_new_organization.go 100.00% <100.00%> (ø)

Copy link
Contributor

@nguyer nguyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@nguyer nguyer merged commit a64ee78 into hyperledger:main Sep 22, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants