Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent unit tests #1463

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Intermittent unit tests #1463

merged 3 commits into from
Feb 15, 2024

Conversation

Philip-21
Copy link
Contributor

@Philip-21 Philip-21 commented Feb 10, 2024

Pr fixes for #1428

Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>
@Philip-21 Philip-21 requested a review from a team as a code owner February 10, 2024 13:50
@Philip-21
Copy link
Contributor Author

Philip-21 commented Feb 10, 2024

@nguyer this pr contains fixes for #1428 , the error seems to be related to connection issues when trying to invoke the webhook and this makes the TLS client unable to establish a connection to the server , so i decided to remove the IP address, and utilize the port number to see if the error exists, But the workflow still awaits approval before it runs

@nguyer
Copy link
Contributor

nguyer commented Feb 12, 2024

@Philip-21 Just to let you know, you can run E2E tests locally as well by running make e2e

@Philip-21
Copy link
Contributor Author

@Philip-21 Just to let you know, you can run E2E tests locally as well by running make e2e

ok thanks

Philip-21 and others added 2 commits February 15, 2024 02:55
Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>
Signed-off-by: Philip Obiora <73377830+Philip-21@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b1fd7dc) 99.99% compared to head (e7572d9) 99.96%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1463      +/-   ##
==========================================
- Coverage   99.99%   99.96%   -0.04%     
==========================================
  Files         322      322              
  Lines       23301    23301              
==========================================
- Hits        23299    23292       -7     
- Misses          1        6       +5     
- Partials        1        3       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nguyer nguyer merged commit d6578db into hyperledger:main Feb 15, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants