Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links at docs #1489

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Fix broken links at docs #1489

merged 2 commits into from
Apr 10, 2024

Conversation

alex-semenyuk
Copy link
Member

No description provided.

Signed-off-by: alexey semenyuk <alexsemenyuk88@gmail.com>
Signed-off-by: alexey semenyuk <alexsemenyuk88@gmail.com>
@alex-semenyuk alex-semenyuk requested a review from a team as a code owner April 7, 2024 09:20
@nguyer
Copy link
Contributor

nguyer commented Apr 9, 2024

@alex-semenyuk All of these links work for me when I browse to https://hyperledger.github.io/firefly/head/tutorials/custom_contracts/ and https://hyperledger.github.io/firefly/head/tutorials/custom_contracts/pinning.html. Is there something that is flagging them as broken?

@alex-semenyuk
Copy link
Member Author

This html links don't work on github https://github.com/hyperledger/firefly/blob/main/docs/tutorials/broadcast_data.html Is it ok?
It seems like there are mix of links - some of them ends with html like https://github.com/hyperledger/firefly/blob/main/docs/tutorials/broadcast_data.html; some of them ends with md like https://github.com/hyperledger/firefly/blob/main/docs/tutorials/custom_contracts/ethereum.md (then it works on github as well)

@nguyer
Copy link
Contributor

nguyer commented Apr 10, 2024

This html links don't work on github https://github.com/hyperledger/firefly/blob/main/docs/tutorials/broadcast_data.html Is it ok?

Ah okay. The docs site is generated by Jekyll and takes all of these files in and generates static HTML for them. So these links do actually work on the real docs site. I don't generally browse the docs right in GitHub as there are lots of things like tables of contents and external file embeds that don't show up there.

However, I'm happy to merge this, because it should not make any difference to the generated docs site, and it does improve the GitHub experience. Thanks.

@nguyer nguyer merged commit e08643c into hyperledger:main Apr 10, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants