Replace UpsertOperation with InsertOperation #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No code path ever passes allowExisting=true, and we already have a separate UpdateOperation method for updates. Therefore, rename this method to InsertOperation and remove the unneeded branches. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
awrichar
commented
Dec 3, 2021
| operation.Output, | ||
| ), | ||
| func() { | ||
| s.callbacks.UUIDCollectionNSEvent(database.CollectionOperations, fftypes.ChangeEventTypeCreated, operation.Namespace, operation.ID) |
There was a problem hiding this comment.
Notably, there is no path where we emit ChangeEventTypeUpdated for operations. The old code gave the impression that there was, but it was in a never-used code branch.
The separate UpdateOperation method does not emit this event, presumably because it may not know the namespace.
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No code path ever passes allowExisting=true, and we already have a separate
UpdateOperation method for updates. Therefore, rename this method to
InsertOperation and remove the unneeded branches.