feat(pollux): PR review feedback #2

prism-agent/service/server/src/main/scala/io/iohk/atala/agent/server/http/ZHttpServer.scala

@@ -15,8 +15,6 @@ import io.iohk.atala.pollux.schema.SchemaRegistryServerEndpoints
 object ZHttpServer {
   val log = LoggerFactory.getLogger(ZioHttpInterpreter.getClass.getName)
 
-  val defaultPort = sys.env.get("http.port").map(_.toInt).getOrElse(8085)
-
   val defaultServerOptions: ZioHttpServerOptions[Any] =
     ZioHttpServerOptions.customiseInterceptors
       .serverLog(
@@ -32,7 +30,7 @@ object ZHttpServer {
 
   def start(
       endpoints: List[ZServerEndpoint[Any, Any]],
-      port: Int = defaultPort,
+      port: Int,
       serverOptions: ZioHttpServerOptions[Any] = defaultServerOptions
   ): ZIO[Scope, Throwable, Any] =
     val app: HttpApp[Any, Throwable] = ZioHttpInterpreter(serverOptions).toHttp(endpoints)

prism-agent/service/server/src/main/scala/io/iohk/atala/pollux/service/SchemaRegistryServiceInMemory.scala

@@ -5,31 +5,27 @@ import io.iohk.atala.pollux.schema.{VerifiableCredentialsSchemaInput, Verifiable
 import java.util.UUID
 import scala.collection.mutable
 
-class SchemaRegistryServiceInMemory(
-    uioRef: UIO[Ref[Map[UUID, VerifiableCredentialsSchema]]] = Ref.make(Map.empty[UUID, VerifiableCredentialsSchema])
-) extends SchemaRegistryService {
-
-  // val storage = new mutable.Map[UUID, VerifiableCredentialsSchema]()
+class SchemaRegistryServiceInMemory(ref: Ref[Map[UUID, VerifiableCredentialsSchema]]) extends SchemaRegistryService {
 
   // TODO: Figure out what is the logic for trying to overwrite the schema with the same id (409 Conflict)
   // TODO: Other validations (same [schema_name, version], list of the attributes is not empty, etc)
   override def createSchema(in: VerifiableCredentialsSchemaInput): Task[VerifiableCredentialsSchema] = {
     val schema = VerifiableCredentialsSchema(in)
     for {
-      ref <- uioRef
       _ <- ref.update(s => s + (schema.id -> schema))
     } yield schema
   }
 
   override def getSchemaById(id: UUID): Task[Option[VerifiableCredentialsSchema]] = {
     for {
-      ref <- uioRef
       storage <- ref.get
       schema = storage.get(id)
     } yield schema
   }
 }
 
 object SchemaRegistryServiceInMemory {
-  val layer = ZLayer.succeed[SchemaRegistryService](new SchemaRegistryServiceInMemory)
+  val layer = ZLayer.fromZIO(
+    Ref.make(Map.empty[UUID, VerifiableCredentialsSchema]).map(SchemaRegistryServiceInMemory(_))
+  )
 }