Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove usage of secp256r1 and demos #1043

Merged
merged 3 commits into from
May 15, 2024

Conversation

shotexa
Copy link
Contributor

@shotexa shotexa commented May 14, 2024

Description:

Remove usage of secp256r1 in test sources and files used for demo of jwt creds in the past

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
Copy link
Contributor

github-actions bot commented May 14, 2024

Integration Test Results

14 files  ±0  14 suites  ±0   2s ⏱️ ±0s
30 tests ±0  30 ✅ ±0  0 💤 ±0  0 ❌ ±0 
33 runs  ±0  33 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 731e067. ± Comparison against base commit 975730a.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 14, 2024

Unit Test Results

 90 files  ±0   90 suites  ±0   20m 26s ⏱️ +28s
759 tests ±0  751 ✅ ±0  8 💤 ±0  0 ❌ ±0 
766 runs  ±0  758 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 731e067. ± Comparison against base commit 975730a.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented May 14, 2024

Coverage Status

coverage: 51.74% (+2.4%) from 49.381%
when pulling 731e067 on ATL-7117-secp256r1-to-secp256k1
into 975730a on main.

Copy link
Contributor

@patlo-iog patlo-iog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment. The rest LGTM.

@shotexa shotexa self-assigned this May 14, 2024
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
@github-actions github-actions bot added the build label May 15, 2024
@@ -85,8 +85,6 @@ lazy val V = new {
val zioPreludeVersion = "1.0.0-RC24"

val apollo = "1.2.14"
val bouncyCastle = "1.78.1"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidentally noticed it was not used by anything

@shotexa shotexa requested a review from patlo-iog May 15, 2024 12:31
Signed-off-by: Shota Jolbordi <shota.jolbordi@iohk.io>
@shotexa shotexa merged commit 998a13a into main May 15, 2024
11 checks passed
@shotexa shotexa deleted the ATL-7117-secp256r1-to-secp256k1 branch May 15, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants