Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add schemaId to the issuance session #1199

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

yshyn-iohk
Copy link
Member

Description:

  • add the schemaId URI to the OID4VCI session when the credential offer is created

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Signed-off-by: Yurii Shynbuiev <yurii.shynbuiev@iohk.io>
Copy link
Contributor

github-actions bot commented Jun 19, 2024

Unit Test Results

 96 files  ±0   96 suites  ±0   22m 5s ⏱️ -37s
826 tests ±0  818 ✅ ±0  8 💤 ±0  0 ❌ ±0 
833 runs  ±0  825 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 2356bfb. ± Comparison against base commit 1712062.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
org.hyperledger.identus.oid4vci.domain.OIDCCredentialIssuerServiceSpec ‑ CredentialServiceImpl - Simple JWT credential issuance - create credential-offer with valid claims
org.hyperledger.identus.oid4vci.domain.OIDCCredentialIssuerServiceSpec ‑ CredentialServiceImpl - Simple JWT credential issuance - create credential-offer with valid claims and schemaId

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jun 19, 2024

Integration Test Results

14 files  ±0  14 suites  ±0   2s ⏱️ ±0s
29 tests ±0  29 ✅ ±0  0 💤 ±0  0 ❌ ±0 
42 runs  ±0  42 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2356bfb. ± Comparison against base commit 1712062.

♻️ This comment has been updated with latest results.

@yshyn-iohk yshyn-iohk added the autoupdate Merge the main branch into a feature branch label Jun 19, 2024
Copy link
Contributor

The main branch cannot be merged into the feature branch without your help 😢

Copy link
Contributor

The main branch cannot be merged into the feature branch without your help 😢

Copy link
Contributor

The main branch cannot be merged into the feature branch without your help 😢

@yshyn-iohk yshyn-iohk merged commit 97f5d83 into main Jun 21, 2024
10 of 11 checks passed
@yshyn-iohk yshyn-iohk deleted the feat/atl-7271-add-schemaId-to-oidc-session branch June 21, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autoupdate Merge the main branch into a feature branch cloud-agent Component: Cloud Agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants