Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ATL-6832 ZIO failures and defects in entity controller #1203

Merged

Conversation

bvoiturier
Copy link
Contributor

Description:

ATL-6832

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
…tity-controller

Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
…tity-controller

Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
…tity-controller

Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
Copy link
Contributor

github-actions bot commented Jun 19, 2024

Unit Test Results

 96 files  ±0   96 suites  ±0   20m 28s ⏱️ -1s
826 tests ±0  818 ✅ ±0  8 💤 ±0  0 ❌ ±0 
833 runs  ±0  825 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit f082215. ± Comparison against base commit 3191d8b.

♻️ This comment has been updated with latest results.

Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
Copy link
Contributor

github-actions bot commented Jun 19, 2024

Integration Test Results

14 files  ±0  14 suites  ±0   2s ⏱️ ±0s
29 tests ±0  29 ✅ ±0  0 💤 ±0  0 ❌ ±0 
42 runs  ±0  42 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f082215. ± Comparison against base commit 3191d8b.

♻️ This comment has been updated with latest results.

Copy link
Member

@yshyn-iohk yshyn-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
Signed-off-by: Benjamin Voiturier <benjamin.voiturier@iohk.io>
Copy link
Contributor

@FabioPinheiro FabioPinheiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bvoiturier bvoiturier merged commit 9050094 into main Jun 21, 2024
11 checks passed
@bvoiturier bvoiturier deleted the feat/ATL-6832-zio-failures-and-defects-in-entity-controller branch June 21, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants