fix: Present Error Handling Job #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bassam Riman <bassam.riman@iohk.io>
CryptoKnightIOG
requested review from
bvoiturier,
yshyn-iohk,
patlo-iog and
mineme0110
as code owners
FabioPinheiro
approved these changes
Jun 20, 2024
| .tapError({ | ||
| (error: PresentationError | DIDSecretStorageError | BackgroundJobError | CredentialServiceError | | ||
| CastorDIDResolutionError | GetManagedDIDError | TransportError) => | ||
| ZIO.logErrorCause( |
There was a problem hiding this comment.
Seems we have error log in several places.
Just make sure we are not double logging
| // case te: TransportError => new RuntimeException(te) | ||
| case ex: IOException => ex | ||
| case ex: Throwable => ex | ||
|
|
||
| sealed trait MercuryError |
There was a problem hiding this comment.
I extended org.hyperledger.identus.shared.models.Failure on my PR.
Or are you also doing that on your next PR?
bvoiturier
approved these changes
Jun 20, 2024
mineme0110
approved these changes
Jun 20, 2024
|
LGTM I have tested the end to end scenarios |
Signed-off-by: Bassam Riman <bassam.riman@iohk.io>
yshyn-iohk
approved these changes
Jun 21, 2024
Integration Test Results14 files 14 suites 2s ⏱️ Results for commit 73516b2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://input-output.atlassian.net/browse/ATL-7264