feat: restore JVM metrics endpoint capability #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
feature/tech-debt-atl-2977-implement-jvm-metrics
branch
from
4a81468
to
d8b3a79
Compare
|
Atala PRISM Code Coverage
Minimum allowed coverage is Generated by 🐒 cobertura-action against aeff870 |
bvoiturier
approved these changes
May 16, 2023
ghost
force-pushed
the
feature/tech-debt-atl-2977-implement-jvm-metrics
branch
from
05159d0
to
4db1cce
Compare
ghost
force-pushed
the
feature/tech-debt-atl-2977-implement-jvm-metrics
branch
from
4db1cce
to
aeff870
Compare
yshyn-iohk
approved these changes
May 17, 2023
|
We need to discuss the purpose of testing the stuff that doesn't belongs to the business logic and is a part of the non-functional/infrastructure integration. |
atala-dev
added a commit
that referenced
this pull request
May 23, 2023
# [1.3.0](prism-agent-v1.2.0...prism-agent-v1.3.0) (2023-05-23) ### Features * restore JVM metrics endpoint capability ([#527](#527)) ([7d603f0](7d603f0))
ghost
pushed a commit
that referenced
this pull request
Aug 17, 2023
…epo subject to the Developer Certificate of Origin (DCO), Version 1.1. 40a0578 fix: consumer variable nesting correction (#606) d0372f1 fix: include helm Chart.yaml in git commit for release process (#604) 63f38d4 feat: add helm-chart for agent (#603) ab9d2b8 docs: ADR for AuthN/AuthZ in multi-tenancy (#537) 7d603f0 feat: restore JVM metrics endpoint capability (#527) 9b1558f feat: migrate issue endpoint to tapir (#516) 4ee0943 feat: Allow override of network name (#295) 6d3e5a0 feat(prism-agent): add JVM metrics endpoint, add health/version endpoint (#390) 2f60f22 Fix/e2e test fixes (#381) 198643e feat(prism-agent): set OAS version to 0.41.0 (#386) 3b348ac fix(infra): set local PRISM_AGENT_VERSION to 0.40.0 (#379) 32787ad ci(shared): added manual feedback for linting and changed linting config (#303) dcb6b51 ci(shared): enable megalinter checks on pullrequests (#300) 405f367 fix(prism-agent): didcomm endpoint now exposed in docker file and with correct path (#241) 2dcf5e3 fix(infra): change didcomm endpoint - remove suffix (#240) 32e33f1 feat(infra): switch to single instance of postgres for running locally (#203) e3a1aa6 feat(infra): switch to APISIX for local running instead of HAProxy (#196) df24ad9 feat(infra): improved scripts for runinng locally or develping locally (#153) dc641b1 chore(shared): move api folder into runnable and reset build settings for dockerRepository and version.sbt (#152) 775880a feat(shared): set OAS servers to `k8s-dev.atalaprism.io` and add API Key auth method - also update local docker-compose implementation (#126) 67bd340 feat(prism-agent): implement Flyway migrations from castor and pollux library and call on agent startup (#117) cd11493 feat(shared): add Flyway Migrations and expose in ZIO Layer to be used in consuming service (#115) a5b583f feat(shared): Add environmnet configuration for Iris DB and bump scala version in other components to enable build (#96) 6e388b3 [ATL-1869] docs: Bootstrap ADR decision log using log4brains, RFC-0016 (#34) Signed-off-by: David Poltorak <david.poltorak@iohk.io>
ghost
mentioned this pull request
antonbaliasnikov
pushed a commit
that referenced
this pull request
Aug 21, 2023
…epo subject to the Developer Certificate of Origin (DCO), Version 1.1. 40a0578 fix: consumer variable nesting correction (#606) d0372f1 fix: include helm Chart.yaml in git commit for release process (#604) 63f38d4 feat: add helm-chart for agent (#603) ab9d2b8 docs: ADR for AuthN/AuthZ in multi-tenancy (#537) 7d603f0 feat: restore JVM metrics endpoint capability (#527) 9b1558f feat: migrate issue endpoint to tapir (#516) 4ee0943 feat: Allow override of network name (#295) 6d3e5a0 feat(prism-agent): add JVM metrics endpoint, add health/version endpoint (#390) 2f60f22 Fix/e2e test fixes (#381) 198643e feat(prism-agent): set OAS version to 0.41.0 (#386) 3b348ac fix(infra): set local PRISM_AGENT_VERSION to 0.40.0 (#379) 32787ad ci(shared): added manual feedback for linting and changed linting config (#303) dcb6b51 ci(shared): enable megalinter checks on pullrequests (#300) 405f367 fix(prism-agent): didcomm endpoint now exposed in docker file and with correct path (#241) 2dcf5e3 fix(infra): change didcomm endpoint - remove suffix (#240) 32e33f1 feat(infra): switch to single instance of postgres for running locally (#203) e3a1aa6 feat(infra): switch to APISIX for local running instead of HAProxy (#196) df24ad9 feat(infra): improved scripts for runinng locally or develping locally (#153) dc641b1 chore(shared): move api folder into runnable and reset build settings for dockerRepository and version.sbt (#152) 775880a feat(shared): set OAS servers to `k8s-dev.atalaprism.io` and add API Key auth method - also update local docker-compose implementation (#126) 67bd340 feat(prism-agent): implement Flyway migrations from castor and pollux library and call on agent startup (#117) cd11493 feat(shared): add Flyway Migrations and expose in ZIO Layer to be used in consuming service (#115) a5b583f feat(shared): Add environmnet configuration for Iris DB and bump scala version in other components to enable build (#96) 6e388b3 [ATL-1869] docs: Bootstrap ADR decision log using log4brains, RFC-0016 (#34) Signed-off-by: David Poltorak <david.poltorak@iohk.io>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Previously, the ZIO metrics library was used to expose JMX metrics. At some point, this was broken, due to a refactor and there are no e2e tests.
This PR fixes the end point such that JMX metrics are available
Checklist
My PR contains...
My changes...
Documentation
Tests